Replace CFtimestamp() with as_timestamp() #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor failure looks unrelated, perhaps due to something similar to this |
|
Since PR #124 added functionality, would you agree to increase the version number to 0.4 (alternatively to 0.3.1) and update the CRAN version? |
|
thanks! |
|
CRAN are on holidays so I'll have to wait a couple weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent update of the package
CFtimerenamed the functionCFtimestamp()toas_timestamp().The old function name was still working but gave a deprecation warning:
"Function CFtimestamp() is deprecated. Use as_timestamp() instead."Related Issue
None documented yet.