Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for CRAN resubmission #54

Merged
merged 20 commits into from
Nov 3, 2021
Merged

Update for CRAN resubmission #54

merged 20 commits into from
Nov 3, 2021

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Oct 27, 2021 •
edited
Loading

  • add an additional build on ubuntu 18.04 which should fail with the legacy libv8 errors (see this build)
  • pulls in @hillalex's webpack/babel fix from transpile to es5 #53
  • fixes some missing vars from in.js, exposed by this
  • include way more from core-js
  • adds a dockerfile for locally testing with old libv8

See 0be842b...i51-cran-update for changes since #53

Fixes #51
Fixes #52

@richfitz
Copy link
Member Author

richfitz commented Oct 27, 2021 •
edited
Loading

Progress so far:

Pending:

@richfitz richfitz mentioned this pull request Oct 28, 2021
Open
@richfitz
Copy link
Member Author

richfitz commented Nov 3, 2021

Submitted to CRAN

@richfitz richfitz marked this pull request as ready for review November 3, 2021 15:25
@richfitz richfitz merged commit 4d9f6dc into master Nov 3, 2021
@richfitz richfitz mentioned this pull request Nov 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest jsonvalidate throws "SyntaxError: Use of const in strict mode." Latest CRAN headaches
2 participants
@richfitz @hillalex