Fix empty response redirect issue introduced by https://github.com/romsar/gonertia/pull/14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and remove an early return after i.Back, so that PUT, PATCH or DELETE requests with an empty 200 responses will get a correct http.StatusSeeOther response status instead of default http.StatusFound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
defer i.copyWrapperResponse(w, w2)before empty response check and remove an early return after i.Back, so that PUT, PATCH or DELETE requests with empty 200 response will get a correct http.StatusSeeOther response status redirect instead of a default http.StatusFound.