allow inject http client #33

inertia.go

@@ -22,8 +22,8 @@ type Inertia struct {
 
 	flash FlashProvider
 
-	ssrURL        string
-	ssrHTTPClient *http.Client
+	ssrURL    string
+	ssrClient *http.Client
 
 	containerID    string
 	version        string
@@ -46,6 +46,7 @@ func New(rootTemplateHTML string, opts ...Option) (*Inertia, error) {
 		sharedProps:         make(Props),
 		sharedTemplateData:  make(TemplateData),
 		sharedTemplateFuncs: make(TemplateFuncs),
+		ssrClient:           &http.Client{},
 	}
 
 	for _, opt := range opts {
@@ -108,6 +109,7 @@ func NewFromTemplate(rootTemplate *template.Template, opts ...Option) (*Inertia,
 		logger:             log.New(io.Discard, "", 0),
 		sharedProps:        make(Props),
 		sharedTemplateData: make(TemplateData),
+		ssrClient:          &http.Client{},
 	}
 
 	for _, opt := range opts {

option.go

@@ -89,7 +89,14 @@ func WithSSR(url ...string) Option {
 		}
 
 		i.ssrURL = u
-		i.ssrHTTPClient = &http.Client{}
+		return nil
+	}
+}
+
+// WithSSRClient returns Option that will set Inertia's SSR http client.
+func WithSSRClient(ssrClient *http.Client) Option {
+	return func(i *Inertia) error {
+		i.ssrClient = ssrClient
 		return nil
 	}
 }

option_test.go

@@ -3,9 +3,11 @@ package gonertia
 import (
 	"io"
 	"log"
+	"net/http"
 	"reflect"
 	"testing"
 	"testing/fstest"
+	"time"
 )
 
 func TestWithVersion(t *testing.T) {
@@ -225,10 +227,6 @@ func TestWithSSR(t *testing.T) {
 			t.Fatalf("unexpected error: %s", err)
 		}
 
-		if i.ssrHTTPClient == nil {
-			t.Fatal("ssr http client is nil")
-		}
-
 		if i.ssrURL != wantURL {
 			t.Fatalf("ssrURL=%s, want=%s", i.containerID, wantURL)
 		}
@@ -247,16 +245,35 @@ func TestWithSSR(t *testing.T) {
 			t.Fatalf("unexpected error: %s", err)
 		}
 
-		if i.ssrHTTPClient == nil {
-			t.Fatal("ssr http client is nil")
-		}
-
 		if i.ssrURL != wantURL {
 			t.Fatalf("ssrURL=%s, want=%s", i.containerID, wantURL)
 		}
 	})
 }
 
+func TestWithSSRClient(t *testing.T) {
+	t.Parallel()
+
+	i := I()
+
+	want := &http.Client{
+		Transport:     nil,
+		CheckRedirect: nil,
+		Jar:           nil,
+		Timeout:       5 * time.Second,
+	}
+
+	option := WithSSRClient(want)
+
+	if err := option(i); err != nil {
+		t.Fatalf("unexpected error: %s", err)
+	}
+
+	if i.ssrClient != want {
+		t.Fatal("ssr http client was not set")
+	}
+}
+
 func TestWithFlashProvider(t *testing.T) {
 	t.Parallel()
 

response.go

@@ -515,7 +515,7 @@ func (i *Inertia) buildInertiaHTML(page *page) (inertia, inertiaHead template.HT
 }
 
 func (i *Inertia) isSSREnabled() bool {
-	return i.ssrURL != "" && i.ssrHTTPClient != nil
+	return i.ssrURL != ""
 }
 
 // htmlContainerSSR will send request with json marshaled page payload to ssr render endpoint.
@@ -529,7 +529,7 @@ func (i *Inertia) htmlContainerSSR(pageJSON []byte) (inertia, inertiaHead templa
 	}
 	setJSONRequest(req)
 
-	resp, err := i.ssrHTTPClient.Do(req)
+	resp, err := i.ssrClient.Do(req)
 	if err != nil {
 		return "", "", fmt.Errorf("execute http request: %w", err)
 	}

response_test.go

@@ -147,7 +147,7 @@ func TestInertia_Render(t *testing.T) {
 					i.rootTemplateHTML = rootTemplate
 					i.version = "f8v01xv4h4"
 					i.ssrURL = ts.URL
-					i.ssrHTTPClient = ts.Client()
+					i.ssrClient = ts.Client()
 				})
 
 				successRunner(t, i)
@@ -171,7 +171,7 @@ func TestInertia_Render(t *testing.T) {
 					i.rootTemplate = tmpl
 					i.version = "f8v01xv4h4"
 					i.ssrURL = ts.URL
-					i.ssrHTTPClient = ts.Client()
+					i.ssrClient = ts.Client()
 				})
 
 				successRunner(t, i)
@@ -189,7 +189,7 @@ func TestInertia_Render(t *testing.T) {
 					i.rootTemplateHTML = rootTemplate
 					i.version = "f8v01xv4h4"
 					i.ssrURL = ts.URL
-					i.ssrHTTPClient = ts.Client()
+					i.ssrClient = ts.Client()
 				})
 
 				errorRunner(t, i)
@@ -214,7 +214,7 @@ func TestInertia_Render(t *testing.T) {
 					i.rootTemplate = tmpl
 					i.version = "f8v01xv4h4"
 					i.ssrURL = ts.URL
-					i.ssrHTTPClient = ts.Client()
+					i.ssrClient = ts.Client()
 				})
 
 				errorRunner(t, i)