Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distortion Solution #284

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Distortion Solution #284

wants to merge 62 commits into from

Conversation

manduhmia
Copy link
Contributor

Describe your changes

Adding distortion solution function

Type of change

  • New feature (non-breaking change which adds functionality)

Reference any relevant issues (don't forget the #)

#160

Checklist before requesting a review

  • I have linted my code
  • I have verified that all unit tests pass in a clean environment and added new unit tests, as needed
  • I have verified that all docstrings are properly formatted and added new documentation, as needed
  • I have filled out the Unit Test Definition Table on confluence, as needed

@manduhmia
final updates to e2e testing params
9b0f4fd
@manduhmia
updating TVAC data path and removing unnecessary ascii import
edb9404
@manduhmia
fixing input error in measuring star offsets for computing plate scal…
34c71f4 
…e and north angle
@manduhmia
Merge branch 'main' of https://github.com/roman-corgi/corgidrp into a…
02f6bfd 
…strom_e2e
@manduhmia
adding function to fit the legendre coeffs for distortion correction
b987bac
@manduhmia
adding function to compute the distortion map coeffs
0a5812f
@manduhmia
adding a distortion coefficient atribute to the astrometric calibrati…
e99c62b 
…on data type
@manduhmia
create function to format the input for distortion map computation
3b9d4d6
@manduhmia
create function to compute the distortion coefficients
b59720e
@manduhmia
update the boresight function to compute distortion map coefficients …
63c8c6b 
…if requested
@manduhmia
update the input data length check
965788f
@manduhmia
Merge branch 'main' of https://github.com/roman-corgi/corgidrp into a…
53fe0f5 
…strom_e2e
@manduhmia
Merge pull request #283 from roman-corgi/main
5554d78 
Merge main into astrom_e2e branch
@manduhmia
Merge branch 'astrom_e2e' of https://github.com/roman-corgi/corgidrp …
eddf6b5 
…into astrom_e2e
@manduhmia
updating docstrings
f08e3cd
@manduhmia
updates to measured_offset functioni (to return errors)
79f9176
@manduhmia
updating astrometry fitting function for distortion map calculation (…
b4abcba 
…adding more function params)
@manduhmia
updating variable assignment after changing measure_offset outputs
d6057f2
@manduhmia
updating previously hard-coded variables
d8fcca2
@manduhmia
updating AstromCal data object input formatting
fbf0acf
@manduhmia
updating create_astrom_data function to include optical distortion
62ab820
@manduhmia
adding distortion coeffs as an attribute of the AstromCal data object
ed4240c
@manduhmia
updating unit test to consider more stars
86ac1f3
@manduhmia
adding sample legendre coeffs for unit testing of distortion map extr…
b7d066b 
…action
@manduhmia
updating the formatting code for distortion to consider star pairs wi…
c04d99d 
…th a central target star instead of all possible pairs
@manduhmia
updating the distortion fitting function to take a new initial guess …
1cb9c8b 
…parameter
@manduhmia
updating mock function to include magnitude in guess table
88aa5f5
@manduhmia
creating a new unit test for the distortion mapping
c5f3431
@manduhmia
updating the cost function to remove for loop through frames and upda…
0001c5f 
…ting formatting function to handle this change
@manduhmia
finalizing the distortion correction unit test
ec5a64e
@semaphoreP
Copy link
Contributor

Please also add a row to the table on the DRP Test Definition page, before we finish the PR (hopefully quick).

@manduhmia
write the distortion correction function
9fb9fb0
@manduhmia
begin writing distortion correction unit test
25ddedd
@manduhmia
updating docstring to reflect new output in measure_offset function
7832abc
@manduhmia
updating function name to be more intuitive: fit_distortion_solution
5879a9b
@manduhmia
adding parameter in boresight_cal to pass in initial guess for distor…
fe75222 
…tion fit
@manduhmia
adding the create_wcs() function
c0820a6
@manduhmia
assuming a 'ROLL' header keyword in the primary header and not saving…
36a5f5a 
… any wcs information in the extension header anymore
@manduhmia
creating a unit test for create_wcs() in l2b_to_l3 step function
e4ea2a7
@manduhmia
fixing incorrect call to image data
594d550
@manduhmia
removing dependence on image ext_hdr values before wcs is created
16154fb
@manduhmia
Merge pull request #298 from roman-corgi/astrom_e2e
6a505ea 
merge astrom_e2e into astrom_b2
@manduhmia
fixing indexing issue when matches are not passed into boresight cal
4489bd2
@manduhmia
updating distortion correction test
49e44ff
@manduhmia
altering boresight_cal to handle just a single filepath of field_matc…
d0612c5 
…hes if the same for every frame of input_dataset
@manduhmia
altering distortion coefficient formatting to be more intuitive
0b9ae6e
@manduhmia
setting default distortion coeffs to produce zero distortion instead …
285977e 
…of np.infs
@manduhmia manduhmia mentioned this pull request Feb 25, 2025
Open
@manduhmia
fixing boresight_calibration dependency on WCS info
b5199ba
@manduhmia
updating specifics of input array format for the AstrometricCalibrati…
49cc1a8 
…on data object
@manduhmia
placing the distortion map testing function inside the test astrom file
6987078
@manduhmia
updating unit test docstrings to be more descriptive
6719543
@manduhmia
Merge branch 'astrom_e2e' into astrom_b2
770f4f6
@manduhmia
Merge pull request #299 from roman-corgi/astrom_b2
4ee1bb7 
Create WCS Header and Apply Distortion Correction to L3
@manduhmia
removing test_distortion_map_creation function because it was merged …
f2a1577 
…into the test_astrom.py file
@manduhmia
adding a check that the error in distortion within the central 1arcse…
c712b66 
…c x 1arsec of the image is less than the expected distortion there (~4mas)
@manduhmia
adding a platescale ext_hdr keyword into the create wcs function
d1c7419
@manduhmia
using arctan function to handle pa differences
3101585
@manduhmia
fixing incorrect syntax that was causing auto-pass for unit test
48379da
@manduhmia
fixing input formatting across several functions
0a27e5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semaphoreP semaphoreP semaphoreP requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@semaphoreP semaphoreP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manduhmia @semaphoreP