-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promises demo in BrightScript (BRS) #12
Promises demo in BrightScript (BRS) #12
Conversation
disc7
commented
Dec 6, 2023
- using simple Network request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Finally got a chance to review this. I added a bunch of comments.
Also, let's establish a more standard location for these demos. Let's do ./demos/<name-of-demo>
. So this could be called simple-demo
or something?
'Simple single request | ||
' simpleExample("http://ip-api.com/json/") | ||
|
||
'Chain requests | ||
' chainExample() | ||
|
||
'Parallel requests | ||
' parallelExample() | ||
|
||
'Simple single request with error response | ||
' simpleExample("http://invalid--url.com") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see a simple UI with a few buttons in it that trigger these various functions. That way devs don't have to uncomment the code to test out a specific flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge what we have? ...will put this on my todo for the new year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks.