Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises demo in BrightScript (BRS) #12

Merged
merged 8 commits into from
Dec 22, 2023

Conversation

disc7
Copy link

@disc7 disc7 commented Dec 6, 2023

  • using simple Network request

@disc7 disc7 changed the title Commit for Promises demo for BrightScript (BRS) Promises demo in BrightScript (BRS) Dec 6, 2023
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Finally got a chance to review this. I added a bunch of comments.

Also, let's establish a more standard location for these demos. Let's do ./demos/<name-of-demo>. So this could be called simple-demo or something?

promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
promises-demo-brightscript/components/MainScene.brs Outdated Show resolved Hide resolved
Comment on lines 9 to 19
'Simple single request
' simpleExample("http://ip-api.com/json/")

'Chain requests
' chainExample()

'Parallel requests
' parallelExample()

'Simple single request with error response
' simpleExample("http://invalid--url.com")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a simple UI with a few buttons in it that trigger these various functions. That way devs don't have to uncomment the code to test out a specific flow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge what we have? ...will put this on my todo for the new year.

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@TwitchBronBron TwitchBronBron merged commit a1dfae8 into rokucommunity:master Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants