add logic for optional chaining

[nadiapadalka]

Added logic for optional Chaining

• added tests as well
• now any warnings do not appear

Addressing #20

[TwitchBronBron]

Looks pretty good. I just have a few questions/suggestions.

[TwitchBronBron]

@nadiapadalka looks like the build is currently failing. Can you fix the issues?

Here are all the commands we run as part of the build.

brs/.github/workflows/build.yml

Lines 25 to 30 in ab5322a

	- run: npm ci
	- run: npm run build
	- run: npm run lint
	- run: npm run prettier
	- run: npm run test
	- run: npm run publish-coverage

[nadiapadalka]

@TwitchBronBron fixed

[nadiapadalka]

@TwitchBronBron Hi! The question to you: how can we see this change in our testing environment? Should we make the new release with this PR included or what?

[TwitchBronBron]

I actually just cut a new release this morning that includes this change. If you upgrade to @rokucommunity/brs v0.45.2, you should see the change.

I apologize for taking so long to get the release out. We were waiting to get a few additional fixes in, and then I got super busy the past few days.

Thanks again for submitting this fix!

[nadiapadalka]

I actually just cut a new release this morning that includes this change. If you upgrade to @rokucommunity/brs v0.45.2, you should see the change.

I apologize for taking so long to get the release out. We were waiting to get a few additional fixes in, and then I got super busy the past few days.

Thanks again for submitting this fix!

oh, good to hear! thanks!

[nadiapadalka]

Next question - maybe you can give the advice to me how to upgrade the version correctly? I tried different steps, but seems they are not working

[TwitchBronBron]

This is a fork of the original project, so you might need to change a reference or two in your code depending on how you're running it. Are you using brs directly or is it being used from another tool?

You might need to do this:

npm uninstall brs
npm install @rokucommunity/brs

If you're using the brs cli directly, that's probably all you need to do

[nadiapadalka]

Thanks! But any succcess from my side. Maybe you can try from your side to run any test? Because everything I see now is like this

[TwitchBronBron]

Are you using roca for your tests? We don't have any control of that project, and I don't believe there's currently a way to override their embedded version of brs to use Rokucommunity/brs.