Detect empty mappings and fail early. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 92.54% 92.95% +0.40%
==========================================
Files 18 18
Lines 2334 2341 +7
Branches 517 519 +2
==========================================
+ Hits 2160 2176 +16
+ Misses 99 94 -5
+ Partials 75 71 -4 ☔ View full report in Codecov by Sentry. |
dhdaines
requested changes
Feb 13, 2024
|
@dhdaines Unit test added, ready to re-review. |
dhdaines
approved these changes
Feb 13, 2024
Letting an empty mapping get loaded will corrupt langs.json.gz, so immediately alert the user they cannot do that! Also, don't override the rules_path if it's already initialized. Fixes: 322
Also, no need to sleep after starting the API since it has the whole run_tests.py time to launch itself. Also, network.json.gz was missed in the files whose status we checked after g2p update.
Pydantic validation errors were previously causing stack trace dumps
joanise
force-pushed
the
dev.ej/322.report-empty-mapping
branch
from
7f0739e to
95bf4be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty mappings cause the g2p database to get corrupted, so block them.
Other changes were things I noticed while fixing this, including some coverage improvements.
Fixes: #322