Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change device spec separator from colon to pipe #35

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

roderickvd
Copy link
Owner

Description

Using a colon as separator in device specifications conflicted with ALSA device names that contain colons. Changed to pipe character which is less likely to appear in device names across platforms (Linux/ALSA, macOS/CoreAudio, Windows/WASAPI).

Related Issues

Fixes #33

Testing

Tested on macOS Ventura & Debian Bookworm.

Due Diligence

Please confirm that you have completed the following tasks by checking the boxes:

  • I have linked any related issues or feature requests.
  • I have selected the appropriate labels for this pull request.
  • I have performed cross-platform testing if possible.
  • I have updated the CHANGELOG.md file with a summary of my changes under the "Unreleased" section.
  • I have kept the pull request as a draft until it is ready for review (if applicable).
  • I have read and understood the Contributing guidelines.

Using a colon as separator in device specifications conflicted with ALSA
device names that contain colons. Changed to pipe character which is less
likely to appear in device names across platforms (Linux/ALSA,
macOS/CoreAudio, Windows/WASAPI).
@roderickvd roderickvd added the bug Something isn't working label Nov 25, 2024
@roderickvd roderickvd self-assigned this Nov 25, 2024
@roderickvd
Copy link
Owner Author

I'm gonna go ahead and merge this immediately. I've been able to reproduce and fix the bug with this.

@roderickvd roderickvd merged commit 075be85 into main Nov 25, 2024
4 checks passed
@roderickvd roderickvd deleted the fix/device-spec-separator branch November 25, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App falis to open provided output device
1 participant