feat: transfer also removes empty log folders #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empty includes log folders with only the info.yml file in it, since it is not transferred. info.yml only provides information about the log generation commands, so it can be safely deleted.
eduardacoppo
force-pushed
the
transfer_also_removes_folders
branch
from
324022f to
921f424
Compare
doudou
reviewed
Feb 20, 2025
Comment on lines
+188
to
+190
| results = log_transfer_results(dataset_path, result, logger: logger) | ||
| remove_dataset_folder_if_empty(dataset_path, logger) | ||
| results |
There was a problem hiding this comment.
I believe that there is a race condition here, especially for process servers: the folder will have only a info.yml until the remote system actually generates some other logs.
I actually believe that with the new system, the folder will be really empty in the end (no info.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-67798]
Tested it by writing unit tests and following the tutorial here