Skip to content

Commit

Permalink
feat: remove log folder if empty
Browse files Browse the repository at this point in the history
empty includes log folders with only the info.yml file in it, since it is not transferred.
info.yml only provides information about the log generation commands, so it can be safely deleted.
  • Loading branch information
eduardacoppo committed Feb 20, 2025
1 parent adb6d33 commit c4462a2
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion lib/syskit/cli/log_runtime_archive.rb
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,24 @@ def self.transfer_dataset(
result = TransferDatasetResult.new(
complete: complete, transfer_results: transfer_results
)
log_transfer_results(dataset_path, result, logger: logger)
results = log_transfer_results(dataset_path, result, logger: logger)
remove_dataset_folder_if_empty(dataset_path, logger)
results
end

def self.remove_dataset_folder_if_empty(dataset_path, logger)
remaining_files = Dir.children(dataset_path) - ["info.yml"]
if remaining_files.empty?
begin
FileUtils.remove_dir(dataset_path)
logger.info("Deleted empty dataset folder: #{dataset_path}")
rescue StandardError => e
logger.error("Failed to delete empty dataset folder " \
"#{dataset_path}: #{e.message}")
end
else
logger.info("Skipping folder deletion: #{dataset_path} is not empty")
end
end

# Logs the transfer dataset results
Expand Down

0 comments on commit c4462a2

Please sign in to comment.