Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sheep Wolf Slitherlink #574

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Conversation

despian
Copy link
Contributor

@despian despian commented Oct 6, 2024

Sheep Wolf Slitherlink variant.

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pzprjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:47am

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.31%. Comparing base (f5a9759) to head (8afde8e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/puzzle/Config.js 0.00% 1 Missing ⚠️
src/variety/slither.js 95.83% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         195      195           
  Lines       21626    21659   +33     
=======================================
+ Hits        19747    19778   +31     
- Misses       1879     1881    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@x-sheep x-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Pull Request! I've left a couple of messages.

src/variety/slither.js Outdated Show resolved Hide resolved
test/script/swslither.js Outdated Show resolved Hide resolved
src/variety/slither.js Outdated Show resolved Hide resolved
src-ui/res/rules.ja.yaml Outdated Show resolved Hide resolved
src/variety/slither.js Outdated Show resolved Hide resolved
src/variety/slither.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@x-sheep x-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this genre is nearly ready. The background is currently kind of distracting, considering the symbols inside the puzzle are also light-gray. Could you try to change the color palette so it's not high contrast and gray? (either making the colors closer together or adding a tint would be fine)

@despian
Copy link
Contributor Author

despian commented Oct 17, 2024

yeah, i wanted to make something interesting and got a bit carried away with the pixel art ... i was also worried it was a bit much. don't have time right now but I'll try some stuff out at the weekend.

@x-sheep
Copy link
Collaborator

x-sheep commented Oct 18, 2024

I do like the pattern itself, just not the selection of colors.

@x-sheep x-sheep merged commit 388b9fa into robx:main Oct 28, 2024
3 checks passed
@x-sheep
Copy link
Collaborator

x-sheep commented Oct 28, 2024

Thanks for the contribution! I ended up making some palette changes to the background myself. If you want a different background, feel free to open a new Pull Request with a different image.

@x-sheep x-sheep added the new genre For requesting or implementing new puzzle genres label Oct 28, 2024
@mfamphlett
Copy link

Sorry, was really busy the last few weekends and this slipped my mind. I think your change looks great!

My idea was maybe to try and incorporate a snake slithering through the dark background to reduce the contrast and make it even more on theme, and possibly add subtle color to each element. Maybe I'll still give that a go if I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new genre For requesting or implementing new puzzle genres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants