-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add couplingICubEye
device
#997
Add couplingICubEye
device
#997
Conversation
We have to get aligned on the name as the Eyes Mk3 do refer to an internal experiment that is obsolete. |
6c52d8b
to
6a20fae
Compare
This PR has been tested with:
@pattacini @traversaro it is ready to be reviewed/merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
Is the device on by default? If not, could it make sense to enable it by default or add it to the default preset? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested together!
Yes it is enabled by default, it does not have external dependencies except YARP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please address the conflicts?
2d767bd
to
cca651e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting the CI before merging.
This pull request introduces the new
couplingICubEye
coupling handler device.Need to test it
It implements the IJointCoupling interface: