Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add couplingICubEye device #997

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

martinaxgloria
Copy link
Contributor

@martinaxgloria martinaxgloria commented Dec 2, 2024

This pull request introduces the new couplingICubEye coupling handler device.
Need to test it
It implements the IJointCoupling interface:

@martinaxgloria martinaxgloria self-assigned this Dec 2, 2024
@martinaxgloria martinaxgloria changed the base branch from master to devel December 2, 2024 15:49
@pattacini
Copy link
Member

We have to get aligned on the name as the Eyes Mk3 do refer to an internal experiment that is obsolete.
Also, Mk2 and Mk4 do have essentially the same mechanism with tiny different kinematic params.

@pattacini pattacini changed the title Add couplingICubEyeMk3 device Add couplingICubEye device Dec 4, 2024
marcoaccame pushed a commit to marcoaccame/icub-main that referenced this pull request Dec 4, 2024
@martinaxgloria martinaxgloria force-pushed the feat/couplingICubEyeMk3 branch from 6c52d8b to 6a20fae Compare December 18, 2024 10:51
@martinaxgloria martinaxgloria marked this pull request as ready for review December 18, 2024 13:45
@Nicogene
Copy link
Member

This PR has been tested with:

@pattacini @traversaro it is ready to be reviewed/merged

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

src/libraries/icubmod/couplingICubEye/CouplingICubEye.h Outdated Show resolved Hide resolved
@traversaro
Copy link
Member

Is the device on by default? If not, could it make sense to enable it by default or add it to the default preset?

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together!

@Nicogene
Copy link
Member

Is the device on by default? If not, could it make sense to enable it by default or add it to the default preset?

Yes it is enabled by default, it does not have external dependencies except YARP

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nicogene @martinaxgloria

Could you please address the conflicts?

@martinaxgloria martinaxgloria force-pushed the feat/couplingICubEyeMk3 branch from 2d767bd to cca651e Compare December 18, 2024 15:45
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting the CI before merging.

@pattacini pattacini merged commit ac3beae into robotology:devel Dec 18, 2024
4 checks passed
@martinaxgloria martinaxgloria deleted the feat/couplingICubEyeMk3 branch December 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants