Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff #153

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Ruff #153

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8, 3.11.1]
rf-version: [5.0.1, 7.0.0]
python-version: [3.8, 3.12]
rf-version: [5.0.1, 7.0.1]

steps:
- uses: actions/checkout@v4
Expand All @@ -26,10 +26,11 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements-dev.txt
pip install uv
uv pip install -r requirements-dev.txt --python ${{ matrix.python-version }} --system
- name: Install RF ${{ matrix.rf-version }}
run: |
pip install -U --pre robotframework==${{ matrix.rf-version }}
uv pip install -U robotframework==${{ matrix.rf-version }} --python ${{ matrix.python-version }} --system
- name: Run ruff
run: |
ruff check ./src tasks.py
Expand Down
2 changes: 1 addition & 1 deletion atest/tests.robot
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Keyword Names
Method
Custom Name
Cust Omna Me
IF $LIBRARY == "ExtendExistingLibrary" Keyword In Extending Library
IF "$LIBRARY" == "ExtendExistingLibrary" Keyword In Extending Library

Method Without @keyword Are Not Keyowrds
[Documentation] FAIL GLOB: No keyword with name 'Not Keyword' found.*
Expand Down
3 changes: 2 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
uv
pytest
pytest-cov
pytest-mockito
robotstatuschecker
black >= 23.7.0
ruff >= 0.0.286
ruff >= 0.5.5
robotframework-tidy
invoke >= 2.2.0
twine
Expand Down
2 changes: 1 addition & 1 deletion src/robotlibcore/core/hybrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def __get_members(self, component):
raise TypeError(
msg,
)
if type(component) != component.__class__:
if type(component) != component.__class__: # noqa: E721
msg = (
"Libraries must be modules or new-style class instances, "
f"got old-style class {component.__class__.__name__} instead."
Expand Down