fix(buildargs): initialize buildargs as map if empty

robolaunch · May 18, 2023 · f75a30a · f75a30a
1 parent d88e49f
commit f75a30a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pipelines/freecad.yaml b/pipelines/freecad.yaml
@@ -28,6 +28,4 @@ steps:
   baseStep: "xfce-withuser"
   path: "dockerfiles/freecad"
   dockerfile: "Dockerfile.freecad"
-  buildArgs:
-    "FREECAD_VERSION": "0.18.4+dfsg2-1ubuntu4"
   push: false
diff --git a/pkg/api/step.go b/pkg/api/step.go
@@ -27,6 +27,7 @@ type Step struct {
 func (step *Step) Default(lc LaunchConfig) {
 	step.setImageName(lc)
 	step.setContext(lc)
+	step.setBuildArgs(lc)
 	step.setBaseImage(lc)
 }
 
@@ -40,6 +41,12 @@ func (step *Step) setContext(lc LaunchConfig) {
 	}
 }
 
+func (step *Step) setBuildArgs(lc LaunchConfig) {
+	if len(step.BuildArgs) == 0 {
+		step.BuildArgs = make(map[string]*string)
+	}
+}
+
 func (step *Step) setBaseImage(lc LaunchConfig) {
 	if _, ok := step.BuildArgs["base_image"]; !ok {
 		baseStep, _ := step.GetBaseStep(lc)