send api key for model registry to make it work on dedicated deployments #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansent
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby and
probicheaux
as code owners
bigbitbus
previously approved these changes
Jan 24, 2025
grzegorz-roboflow
previously approved these changes
Jan 24, 2025
PawelPeczek-Roboflow
previously approved these changes
Jan 24, 2025
grzegorz-roboflow
dismissed stale reviews from PawelPeczek-Roboflow and themself
via
ad82159
grzegorz-roboflow
approved these changes
Jan 24, 2025
PawelPeczek-Roboflow
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the /model/registry endpoint usually doesnt require api keys when run locally. However on dedicated deployments all requests need to pass api key to validate they come from workspace that the dedicated deployment belongs to.
Without this change the benchmark cli tool doesn't work.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
locally
Any specific deployment considerations
n/a
Docs
n/a