Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection Offset - Use bbox for percent padding #970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sberan
Copy link
Contributor

@sberan sberan commented Jan 22, 2025

Description

Padding bounding boxes by percent rather than pixels is a new feature (implemented in https://github.com/roboflow/inference/pull/956/files) and I don't think was implemented correctly. When talking with potential users, they want padding based on a percentage of the size of the bounding box, not the size of the image. This is done because larger detections need more padding because they are closer to the camera. I don't think padding based on image size is very useful. I'm hoping since this functionality is new enough and was implemented for a specific use case that we can modify it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Unit tests cover this change fully.

Any specific deployment considerations

n/a - standard deploy

Docs

  • Updated description of input to reflect the use of bounding box percent.

@sberan sberan force-pushed the padding-percent-of-bbox branch from 8991e69 to abdb3cf Compare January 22, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant