Detection Offset - Use bbox for percent padding #970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Padding bounding boxes by percent rather than pixels is a new feature (implemented in https://github.com/roboflow/inference/pull/956/files) and I don't think was implemented correctly. When talking with potential users, they want padding based on a percentage of the size of the bounding box, not the size of the image. This is done because larger detections need more padding because they are closer to the camera. I don't think padding based on image size is very useful. I'm hoping since this functionality is new enough and was implemented for a specific use case that we can modify it.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Unit tests cover this change fully.
Any specific deployment considerations
n/a - standard deploy
Docs