Send raw image over WebRTC if no visualisation is available #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz-roboflow
requested review from
PawelPeczek-Roboflow,
yeldarby,
probicheaux and
hansent
as code owners
PawelPeczek-Roboflow
previously approved these changes
Jan 22, 2025
PawelPeczek-Roboflow
approved these changes
Jan 22, 2025
grzegorz-roboflow
deleted the
fix/send-raw-image-over-webrtc-if-no-visualisation-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When handling stream through WebRTC we currently expect image to be available. It is possible workflow branch with image generation was not executed - in such case we should send raw image.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
CI passing
E2E tested
Any specific deployment considerations
N/A
Docs
N/A