Reapply "Added ResNet Classification Model Support" #959
+261
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15d7436.
Matvezy
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
| @@ -35,6 +35,9 @@ class ClassificationBaseOnnxRoboflowInferenceModel(OnnxRoboflowInferenceModel): | |||
|
|
|||
| task_type = "classification" | |||
|
|
|||
| preprocess_means = [0.5, 0.5, 0.5] | |||
There was a problem hiding this comment.
I believe hardcoding such values in code is not great (I know - it was that before) - ideally that should be delivered in model metadata
There was a problem hiding this comment.
I agree, will update it in the future iterations. It was actually part of the reason the previous PR attempt broke.
PawelPeczek-Roboflow
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15d7436.
Description
This is a fix for #943
Now the code is fixed and passed the problematic tests: https://github.com/roboflow/inference/actions/runs/12838521825
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
GHA
Any specific deployment considerations
N/A
Docs