2025 soccer draft rules global rules #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include the general rules from the `general-rules` submodule * Update the .github/workflows/build.yml to use a new version of the `checkout` action. Signed-off-by: mr.Shu <[email protected]>
* Make sure the General Rules are discrete. Signed-off-by: mr.Shu <[email protected]>
Signed-off-by: mr.Shu <[email protected]>
Signed-off-by: mr.Shu <[email protected]>
mrshu
requested review from
dbscoach,
Adman,
aquahika,
rbonill,
willplum,
javier687,
marcodankel and
margauxmedwards
mrshu
commented
Nov 13, 2024
| @@ -4,7 +4,9 @@ jobs: | |||
| name: build | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v4 | |||
| @@ -17,7 +17,7 @@ endif::basebackend-html[] | |||
| :icons: font | |||
| :numbered: | |||
|
|
|||
| These are the Soccer rules for RoboCupJunior 2024. They are released | |||
| These are the Soccer rules for RoboCupJunior 2025. They are released | |||
There was a problem hiding this comment.
@javier687 thanks a bunch for pointing this out!
* Make sure the logos are shown on the first page too Signed-off-by: mr.Shu <[email protected]>
mrshu
force-pushed
the
2025-soccer-draft-rules-global-rules
branch
from
c9692f4 to
4b48d50
Compare
Adman
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your change in one or two sentences
Add the Global Rules as a submodule of its repository (https://github.com/robocup-junior/general-rules) and include it in the rule text (via the
includecommand).Please explain why do you think this change should be in the rules
To make sure the General Rules are included inside the text of the soccer rules.