Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release rules as final #113

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Conversation

dbscoach
Copy link
Contributor

Please describe your change in one or two sentences

Removed all references to the rules being draft rules

Please explain why do you think this change should be in the rules

Fortunately no significant changes were needed from what we put out as a draft after community feedback.

David Schwarz and others added 13 commits August 10, 2023 07:41
Signed-off-by: David Schwarz <[email protected]>
Signed-off-by: David Schwarz <[email protected]>
* Add rule regarding ball play on the nearest neutral spot

* make it the referees discretion to deem a robot damaged if it does not play the ball

* Fix criticmarkup so bolding is rendered correctly

Signed-off-by: David Schwarz <[email protected]>

* Add hint about blocked neutral spot situations to ball-approach-rule

Signed-off-by: David Schwarz <[email protected]>

* Incorporate @mrshu s phrasing suggestion

Signed-off-by: David Schwarz <[email protected]>

---------

Signed-off-by: David Schwarz <[email protected]>
Co-authored-by: dankel <[email protected]>
Co-authored-by: David Schwarz <[email protected]>
Note that the goal should not contain the wedge
@dbscoach dbscoach requested review from mrshu and Adman November 25, 2023 21:25
@dbscoach dbscoach changed the title Release draft rules as final Release rules as final Nov 25, 2023
@dbscoach dbscoach requested a review from willplum November 25, 2023 21:48
@dbscoach dbscoach force-pushed the dbscoach/de-draftify-for-final-release branch from 798e19a to 9cce903 Compare November 25, 2023 21:51
@dbscoach dbscoach requested a review from MikeRCJ November 25, 2023 21:52
@@ -41,6 +42,9 @@
\usepackage[defaultsans]{droidsans}
\renewcommand{\familydefault}{\sfdefault}

%\SetWatermarkText{Draft}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the things the non-LaTeX rules will have a very very tough time implementing... 🙂

Thanks for doing this @dbscoach!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the watermark isn't the only hint at being draft rules and also don't get passed around and re-uploaded as much.

the ball does not return further than the front line of to the penalty area
it was shot from.++}

[[kicker-power-measure-preamble]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot believe seeing this much red makes me so happy...

@dbscoach dbscoach merged commit 0c4b95f into master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants