Fix mapping of centered signs #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue with the MapAnswer solution placing victims/hazards signs in the wrong cell when they appear in the middle of the wall.
I added the following picture to explain the problem better:
I made a few changes to the MapAnswer class in order to test the code independently from webots. Now the MapAnswer has its own representation of the world and we only need to interact with the Supervisor to gather this data at creation time.
I used a bunch of different test files to make sure everything is working as intended. I didn't commit those changes here, but if you want to take a look: https://github.com/RichoM/erebus/tree/master/test