Add defaults for pydantic fields #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 suggestion.
Files not reviewed (3)
- tests/data/graph_response_no_u.json: Language not supported
- src/pylibrelinkup/models/hardware.py: Evaluated as low risk
- src/pylibrelinkup/models/data.py: Evaluated as low risk
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- tests/data/graph_response_no_u.json: Language not supported
- src/pylibrelinkup/models/data.py: Evaluated as low risk
- src/pylibrelinkup/models/hardware.py: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pylibrelinkupproject, focusing on adding default values to model fields and updating tests to handle new fixtures. The most important changes include setting default values for various fields in multiple models and adding new test fixtures and test cases.Model Updates:
src/pylibrelinkup/models/config.py: Added default values to fields inAlarmRulesandFixedLowAlarmValuesclasses. [1] [2]src/pylibrelinkup/models/connection.py: Added default values to fields inConnection,Ticket, andGraphResponseclasses. [1] [2] [3]src/pylibrelinkup/models/data.py: Added default values to fields inGlucoseMeasurement,F,L,H, andNdclasses. [1] [2] [3] [4] [5]src/pylibrelinkup/models/hardware.py: Added default values to fields inSensorandPatientDeviceclasses. [1] [2]src/pylibrelinkup/models/login.py: Added default values to fields inLlu,SystemMessages,User,Notifications,DataMessages,AuthTicket,LoginResponse,LoginResponseUnauthenticated,LoginRedirectData, andLoginArgsclasses. [1] [2] [3]Test Updates:
tests/conftest.py: Added a new fixturegraph_response_no_u_json.tests/data/graph_response_no_u.json: Added new test data for the fixturegraph_response_no_u_json.tests/test_client_graph.py: Added a new test casetest_graph_response_no_u_returns_graph_responseto handle the new fixture.