Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test formula in Travis CI #9

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Test formula in Travis CI #9

merged 1 commit into from
Jun 19, 2019

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Jun 19, 2019

Fixes #3.

@ronaldtse ronaldtse merged commit 74e2163 into master Jun 19, 2019
@ronaldtse
Copy link
Contributor

Looks great. Thanks @skalee !

@ronaldtse ronaldtse deleted the travis branch June 19, 2019 23:23
@dewyatt
Copy link
Contributor

dewyatt commented Jun 21, 2019

What's the purpose of allowing failures on this?

@skalee
Copy link
Contributor Author

skalee commented Jun 23, 2019

@dewyatt Because unstable Rnp master does not mean that formula is unstable.

@dewyatt
Copy link
Contributor

dewyatt commented Jun 23, 2019

@skalee Oops I actually read the matrix wrong, it looked like a single entry that was allowed to fail, which didn't make sense. I see the osx_image section now.

@skalee
Copy link
Contributor Author

skalee commented Jun 25, 2019

@ronaldtse I am not sure if it was intentional, but tests are run on travis-ci.com, not on .org. I am okay with that though.

@ronaldtse
Copy link
Contributor

Travis is migrating all .org to .com, so newer enabled repos are all done on .com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Travis build
3 participants