Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olexiy troschij #15

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Olexiy troschij #15

wants to merge 9 commits into from

Conversation

OlexiyTr
Copy link
Collaborator

@OlexiyTr OlexiyTr commented Feb 1, 2021

Description

Please include summary of the change in english

How has this been tested?

  • Executed code few times from start to end without crashing
  • Only ran once
  • Code have dedicated unit tests

@OlexiyTr OlexiyTr requested a review from ARKAD97 as a code owner February 5, 2021 03:32
Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move you work to the /[username]_code location, as described in readme
https://github.com/rnd4u-org/2021-knu-cairl#development

Other than that - LGTM 👍

rescale = tf.keras.layers.experimental.preprocessing.Rescaling(1./127.5, offset= -1)

IMG_SHAPE = IMG_SIZE + (3,)
base_model = tf.keras.applications.MobileNetV2(input_shape=IMG_SHAPE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using mobilenet it's better to use 224x224 image shape

https://keras.io/api/applications/mobilenet/

But yeah, should work with 160, not an error, just may impact accuracy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants