Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artembielov #13

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Artembielov #13

wants to merge 21 commits into from

Conversation

blinddegimon
Copy link
Collaborator

Description

Please include summary of the change in english

How has this been tested?

  • Executed code few times from start to end without crashing
  • Only ran once
  • Code have dedicated unit tests

Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Looks Good To Me :D

from mlxtend.regressor import StackingRegressor


path = 'D:/projects/Python/Samsung2/House price/data/'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the future:
try not to include paths, IPs, personal details on any other personalized or secret data into github commits
This kind of data may unintentionally leak some secret information about a business if you working in a commercial project

@meanalexrin meanalexrin self-requested a review February 1, 2021 09:20
Copy link
Collaborator

@meanalexrin meanalexrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move you work to the /[username]_code location, as described in readme
https://github.com/rnd4u-org/2021-knu-cairl#development

@meanalexrin
Copy link
Collaborator

Please move you work to the /[username]_code location, as described in readme
https://github.com/rnd4u-org/2021-knu-cairl#development

@blinddegimon blinddegimon requested a review from ARKAD97 as a code owner February 8, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants