Skip to content

Commit

Permalink
version 0.4.3
Browse files Browse the repository at this point in the history
Fixed IFREMER datasetID in vignette
  • Loading branch information
rmendels committed Sep 21, 2019
1 parent a27df3c commit 18995ef
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 8 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: rerddapXtracto
Type: Package
Title: Extracts Environmental Data from 'ERDDAP' Web Services
Version: 0.4.2
Version: 0.4.3
Authors@R: person("Roy", "Mendelssohn", email = "[email protected]", role = c("aut","cre"))
Description: Contains three functions that access
environmental data from any 'ERDDAP' data web service. The rxtracto() function extracts
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# rerddapXtracto 0.4.3

- fixed vignette to reflect new datasetID at IFREMER ERDDAP

# rerddapXtracto 0.4.2

- fixed vignette to reflect new datasetID at IFREMER ERDDAP
Expand Down
13 changes: 7 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## update Version 0.4.2
## update Version 0.4.3

Should fix the notes and warnings in CRAN nightly builds
Fixes the warnings in the CRAN nightly builds
The DESCRIPTION file specifically says will not work with old-release

## Test environments
* local OS X install, R 3.6.1
Expand All @@ -11,7 +12,7 @@ Should fix the notes and warnings in CRAN nightly builds

On Mac OS X I get:

Duration: 1m 17.8s
Duration: 2m 4.4s

0 errors v | 0 warnings v | 0 notes v

Expand All @@ -20,9 +21,9 @@ On rhub Windows Server I get:
* checking examples ... NOTE
Examples with CPU (user + system) or elapsed time > 5s
user system elapsed
rxtracto 0.28 0.08 6.55
rxtracto_3D 0.10 0.01 5.87
rxtractogon 0.07 0.00 5.84
rxtracto 0.35 0.07 7.76
rxtracto_3D 0.08 0.02 6.18
rxtractogon 0.06 0.00 7.46
** found \donttest examples: check also with --run-donttest

On rhub Fedora I get:
Expand Down
2 changes: 1 addition & 1 deletion vignettes/UsingrerddapXtracto.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ ifrTimes <- c("2013-09-15", "2013-09-15")
ifrLats <- c(30., 50.)
ifrLons <- c(-140., -110.)
ifrDepth <- c(75., 75.)
dataInfo <- rerddap::info("NRTOA", url = urlBase)
dataInfo <- rerddap::info("CORIOLIS_GLOBAL_NRTOA_OBS_TIME_SERIE_PSAL", url = urlBase)
ifrPSAL <- rxtracto_3D(dataInfo, parameter = parameter, xcoord = ifrLons, ycoord = ifrLats, tcoord = ifrTimes, zcoord = ifrDepth, zName = 'depth')
str(ifrPSAL)
```
Expand Down

0 comments on commit 18995ef

Please sign in to comment.