Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chardonnay window closing (#1065) #1066

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

Mbucari
Copy link
Collaborator

@Mbucari Mbucari commented Dec 5, 2024

This was a nasty little bug to track down!
Between versions 11.0.5 and 11.2.1, Avalonia changed how the classic desktop lifetime worked.
Long story short, I removed some of the parallelism (did testing and found it was only saving a few tens of milliseconds) and used Avalonia's built-in StartWithClassicDesktopLifetime method.

@rmcrackan
Copy link
Owner

Oh my gawd you are my g-- d--- hero. Life has been one kick in the nuts after another lately and I was not looking forward to tracking this down. Maybe I'll put that time toward figuring out why the docker build keeps failing. But honestly, I don't officially support it so I'll probably wait for a docker bro to chime in.

Seriously, I can't tell you what a relief this is.

@Mbucari
Copy link
Collaborator Author

Mbucari commented Dec 5, 2024

You're very welcome XD

I'll always try to be around for stuff like this. Just @ me like you do and I'll probably see the email lol.

@rmcrackan
Copy link
Owner

I'm too unsober to do a release tonight. I'll do the merge and pre-release tomorrow and ask the user/s in #1065 to try it. Thank you again. How've you been by the way? It's been a while.

@Mbucari
Copy link
Collaborator Author

Mbucari commented Dec 5, 2024

I'm too unsober to do a release tonight.

Ditto. Probably not the best time to be doing debugging, but hey, it worked. I must have been near the Ballmer Peak, but I'm past it now!

How've you been by the way? It's been a while.

Really good, actually. I've been dating a wonderful woman for 9 months. I'm in the best shape of my life. And I'm even not hating my job as much lol. I've been off the computer more, and i think that's really improved my health.

How about you? Is your work still a bloodbath?

@rmcrackan
Copy link
Owner

My work is worse than ever. I found a great new company and I killed the interviews ... until the final one. There's also family tragedy which I won't do into. We just had a very nice vacation though. And we all have our health. Looking forward to xmas. We put the tree up tonight and will decorate it tomorrow. That will be fun. Aside from probably too much drinking I'm actually in good shape also -- my exercise routine isn't extreme but I'm religious about doing it daily and it adds up. My eating habits are good also. Getting off the computer more is a good idea -- I should follow suite. I was mostly off of computers last week and although I was less informed about current events, I was also less stressed about them too. Congrats on your love life. Sounds like it must be reasonably serious -- anything past 6-9 months is a long time.

@rmcrackan
Copy link
Owner

Work had full company "town hall" this morning and it's not quite as abysmal as the last town hall. Maybe things will turn a corner.

@rmcrackan rmcrackan merged commit a1c8fb5 into rmcrackan:master Dec 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants