release 1.30.0

[iaguis]

🐙

[lucab]

Lowercase store.

[lucab]

On a recent build system, stage1-kvm now fails to build with:

util/memfd.c:40:12: error: static declaration of ‘memfd_create’ follows non-static declaration
 static int memfd_create(const char *name, unsigned int flags)
            ^~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/bits/mman-linux.h:115:0,
                 from /usr/include/x86_64-linux-gnu/bits/mman.h:45,
                 from /usr/include/x86_64-linux-gnu/sys/mman.h:41,
                 from /home/.../src/github.com/rkt/rkt/build-rkt-1.30.0/tmp/usr_from_kvm/qemu/src/include/sysemu/os-posix.h:29,
                 from /home/.../src/github.com/rkt/rkt/build-rkt-1.30.0/tmp/usr_from_kvm/qemu/src/include/qemu/osdep.h:104,
                 from util/memfd.c:28:
/usr/include/x86_64-linux-gnu/bits/mman-shared.h:46:5: note: previous declaration of ‘memfd_create’ was here
 int memfd_create (const char *__name, unsigned int __flags) __THROW;
     ^~~~~~~~~~~~
make[1]: *** [util/memfd.o] Error 1

[iaguis]

Weird, I've built a release successfully following the release guide. I get this is not building inside rkt, right?

I tried building directly on my laptop and I get an earlier error when building qemu:

set -e;   cd /home/iaguis/work/go/src/github.com/rkt/rkt/build-rkt/tmp/usr_from_kvm/qemu/src; ./configure --disable-bsd-user --disable-docs --disable-guest-agent --disable-guest-agent-msi --disable-sdl --disable-gtk --disable-vte --disable-curses --disable-cocoa --disable-brlapi --disable-vnc --disable-seccomp --disable-curl --disable-bluez --disable-cap-ng --disable-rbd --disable-libiscsi --disable-libnfs --disable-smartcard --disable-libusb --disable-glusterfs --disable-archipelago --disable-tcmalloc --disable-jemalloc --disable-debug-info --static --enable-virtfs --target-list=x86_64-softmmu --python=/usr/bin/python2 --disable-werror ; touch "/home/iaguis/work/go/src/github.com/rkt/rkt/build-rkt/stamps/__stage1_usr_from_kvm_qemu_mk_conf.stamp"

ERROR: sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T.
       You probably need to set PKG_CONFIG_LIBDIR
       to point to the right pkg-config files for your
       build target

make: *** [stage1/usr_from_kvm/qemu.mk:54: /home/iaguis/work/go/src/github.com/rkt/rkt/build-rkt/stamps/__stage1_usr_from_kvm_qemu_mk_conf.stamp] Error 1

It seems something is wrong with my glib headers' config but I haven't looked further into it.

[lucab]

Yes, this is outside of the rkt-builder. I was just doing the usual pre-flight check on my local machine before building the release artifact. I think I have a fix for that, looking at it now.

Your error is unrelated, I seem to remember having seen that already. I remember that it was related to arch-linux not shipping one of the static libraries qemu autoconf is looking for, but I don't remember which.

[lucab]

@iaguis #3922 fixes that build failure.

In the meanwhile, docker2aci regressed with go-1.10 at appc/docker2aci#259. Thus I'd like to bump docker2aci in here with the fix before tagging v1.30.0.

[iaguis]

In the meanwhile, docker2aci regressed with go-1.10 at appc/docker2aci#259. Thus I'd like to bump docker2aci in here with the fix before tagging v1.30.0.

OK. Interesting issue btw :)

[iaguis]

Rebased to include #3922 and #3923

[taqtiqa-mark]

@lucab, regarding your comment about brining in docker2aci:
Would theses changes resolve the Buildah compatibility issue inappc/docker2aci/issues/257. Like the users in that issue I'm using woofwoofinc's build of docker2aci.

Related, and in case it confirms anything you've seen: with rkt fetch... then rkt image export... I get images that are about twice the size of what I get from skopeo copy... then (Woof Woof Inc) docker2aci ....
I'm still trying to get time to make a minimal rep example, but thought to mention it in case it correlates with anything you've seen/experienced.

[lucab]

@taqtiqa-mark no, those are unrelated and only fix a go-1.10 regression, see #3923.

[lucab]

LGTM