Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): switch lodash.isEqualWith to fast-equals comparator to improve performance #4446

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

igorbrasileiro
Copy link
Contributor

Reasons for making this change

This PR replaces lodash.isEqualWith with fast-equals.createCustomEqual at @rjsf/utils.deepEquals as the second part of this approach #4291 (comment) .
first part #4438

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Copy link
Member

@heath-freenome heath-freenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorbrasileiro Thanks for your hard work! Let's see whether this causes any regressions.

@heath-freenome heath-freenome merged commit 2b5c907 into rjsf-team:main Jan 17, 2025
5 checks passed
@igorbrasileiro
Copy link
Contributor Author

igorbrasileiro commented Jan 17, 2025

@igorbrasileiro Thanks for your hard work! Let's see whether this causes any regressions.

Yeah, if something bad happens, feel free to reach me out/tag here. @heath-freenome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants