feat: switch lodash.isEqual to fast-equals.deepEqual to improve performance
#4438
+43
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
Comment on lines
19
to
28
| # 5.25.0 | ||
|
|
||
| ## @rjsf/utils | ||
|
|
||
| - Switched uses of `lodash.isEqual()` to `fast-equals.deepEqual()` in many utility functions. | ||
|
|
||
| ## @rjsf/validator-ajv8 | ||
|
|
||
| - Switched uses of `lodash.isEqual()` to `fast-equals.deepEqual()` at precompiledValidator. | ||
|
|
There was a problem hiding this comment.
5.24.0 has yet to be release so you can move these underneath that section
| @@ -1,4 +1,4 @@ | |||
| import isEqual from 'lodash/isEqual'; | |||
| import { deepEqual } from 'fast-equals'; | |||
There was a problem hiding this comment.
Can you switch these to all use the @rjsf/utils deepEquals() first? And then in a second PR switch deepEquals to use this function?
…formance" This reverts commit 86570fe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
partially fixes #4291
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.