fix: rollback isValid() in retrieveSchema() to validateFormData()
#4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retrieveSchema() (rjsf-team#3575)" This reverts commit ff46301.
4 tasks
| @@ -218,6 +218,7 @@ describeRepeated('Form common', (createFormComponent) => { | |||
|
|
|||
| it('should work with oneOf', function () { | |||
| const schema = { | |||
| $schema: 'http://json-schema.org/draft-06/schema#', | |||
There was a problem hiding this comment.
Is this a necessary part of the fix? Or were you just testing something?
| @@ -25,6 +25,7 @@ should change the heading of the (upcoming) version to include a major version b | |||
| ## @rjsf/utils | |||
|
|
|||
| - Short-circuit `File` and `Date` constructor access in isObject to optimize performance in scenarios where `globalThis` is a `Proxy` that incurs overhead for each class constructor access ([#4413](https://github.com/rjsf-team/react-jsonschema-form/pull/4413)). Fixes [#4409](https://github.com/rjsf-team/react-jsonschema-form/issues/4409) | |||
| - Rollback `isValid()` in `retrieveSchema()` to `validateFormData()` to prevent a bug with empty enums blocking dependencies ([#4418](https://github.com/rjsf-team/react-jsonschema-form/pull/4418)). Fixes [#4357](https://github.com/rjsf-team/react-jsonschema-form/issues/4357) | |||
There was a problem hiding this comment.
Since we've released 5.23.2 already and are currently working on 5.24.0, can you move this to there?
|
@cewald It looks like something in the utils tests are breaking. Can you please take a look... Also there are a few questions/concerns to address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #4357
This reverts commit ff46301
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.