Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew build fixes #3395

Closed
wants to merge 2 commits into from
Closed

Homebrew build fixes #3395

wants to merge 2 commits into from

Conversation

ret2libc
Copy link
Member

@ret2libc ret2libc commented Feb 22, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • allow packager to use absolute paths for plugins/wwwroot/sdb/etc. directories, even outside the prefix

Test plan

  • compile regularly
  • compile with -Drizin_plugins=/system/dir/outside/prefix

Closing issues

...

@XVilka
Copy link
Member

XVilka commented Feb 23, 2023

Maybe create a CI job that tests some simple plugin? Like we test pkg-config/cmake availability on Windows, for example?

@ret2libc ret2libc force-pushed the dist-absolute-paths branch from 35ad621 to 8251f2d Compare February 23, 2023 21:06
@ret2libc ret2libc force-pushed the dist-absolute-paths branch from 8251f2d to b6f3469 Compare March 7, 2023 10:59
@ret2libc ret2libc force-pushed the dist-absolute-paths branch from 0a387e0 to 39234a8 Compare March 7, 2023 17:38
@ret2libc ret2libc closed this May 19, 2023
@ret2libc ret2libc deleted the dist-absolute-paths branch August 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants