Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variables documentation to the book #125

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

satk0
Copy link
Contributor

@satk0 satk0 commented Jul 11, 2024

It aims to resolve the rizin issue rizinorg/rizin#4445, but its NOT yet ready to merge !

While trying to solve it, I've met 2 problems:

  • I don't know where to put rizin env vars doc (in a 16. Build Variables or create a new chapter?)
  • rz-test is not documented, so nowhere to put env var doc (should I also document rz-test?)

@wargio
Copy link
Member

wargio commented Jul 12, 2024

Yes add a new section called Run-Time Variables after the Build Variables and probably we could rename Build Variables to Compile-Time Variables

@wargio
Copy link
Member

wargio commented Jul 12, 2024

@XVilka @kazarmy what do you think?

@wargio wargio marked this pull request as draft July 12, 2024 03:07
@wargio wargio self-assigned this Jul 12, 2024
@wargio wargio added the section label Jul 12, 2024
@wargio
Copy link
Member

wargio commented Jul 12, 2024

Regarding rz-test, it's not mapped in the book, because it is supposed to not be used by a user. its usage is available on the rizin repo itself: https://github.com/rizinorg/rizin/tree/dev/test#usage

@satk0
Copy link
Contributor Author

satk0 commented Jul 12, 2024

Thanks for the answer. So I will just omit rz-test and focus on adding the new section and renaming Build Variables one.

@satk0
Copy link
Contributor Author

satk0 commented Jul 12, 2024

Done, let me know how it looks

_quarto.yml Outdated Show resolved Hide resolved
@satk0
Copy link
Contributor Author

satk0 commented Jul 12, 2024

Done, that's the whole list of env vars that you can print with -hh command.

@wargio wargio marked this pull request as ready for review July 14, 2024 09:32
@wargio wargio merged commit 2aef43b into rizinorg:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants