Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modernize library #33

Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat: modernize library #33

merged 5 commits into from
Sep 9, 2024

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Aug 30, 2024

No description provided.

@shyim shyim force-pushed the modernize-package branch from b05eeb1 to 8773e0e Compare September 3, 2024 06:58
@shyim shyim marked this pull request as ready for review September 3, 2024 07:10
@shyim
Copy link
Contributor Author

shyim commented Sep 3, 2024

@rezigned This is ready 😅

->setFinder(
(new Finder())
->in([__DIR__ . '/src', __DIR__ . '/tests'])
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at the end.

level: 5
paths:
- src
- tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Member

@rezigned rezigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All goods and thank you for the help! 👍 (now the question is how should we version this 😅)

@rezigned rezigned merged commit b36fe7d into rize:master Sep 9, 2024
6 checks passed
@shyim shyim deleted the modernize-package branch September 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants