Add data_type to EncryptedData and switch to binary channel payload encoding #2097
+203
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncoding this ended up being a large change - but mostly to just get the persistence layer changed over. Olm still encrypts and decrypts strings… For new encrypted data code where `dataType.length > 0` - accept bytes to encode, use bin_toHex to convert to string before encrypting - after decrypting, convert back to bytes with bin_fromHex before returning For old data - after decrypting, convert to bytes with text encoder, - for strings (usernames etc) textDecoder will convert back in the rest of the codebase - for channel payloads, handle this case because `dataType` is unset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sergekh2
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ended up being a large change - but mostly to just get the persistence layer changed over.
Olm still encrypts and decrypts strings…
For new encrypted data code where
dataType.length > 0For old data
dataTypeis unset