Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP node: add support to recover from missing a stream update event #2091

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bas-vk
Copy link
Contributor

@bas-vk bas-vk commented Jan 20, 2025

It is possible that a node misses the log/receipt of a setStreamLastMiniblock transaction due to a restart, RPC provider problem, or ... Currently the node tries to register a new miniblock candidate and succeeds due to relaxed checks in the stream registry contract. With these checks enabled it will go into an endless loop of trying to register a miniblock candidate that fails over and over again.

This change enables the checks in the contract again and adds the ability to the river node to detect and recover from a situation where a mini-block candidate fails to register because it was already registered.

TODO:

  • discuss (test) approach
  • determine if we want to enable 1 of 1 writes again, or keep on 1 of N (currently 50) or query the current config setting and use that in the check.
  • determine if the node needs to loop over all pending miniblock candidates on boot and check if these are registered in the time it was down. The current approach will remediate this situation if a stream has a non-empty minipool which (I think?) is the case with a pending miniblock candidate in its storage.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
river-sample-app ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:49pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant