Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for neumes encoded line by line #3571

Merged
merged 113 commits into from
May 9, 2024

Conversation

lpugin
Copy link
Contributor

@lpugin lpugin commented Jan 10, 2024

This PR add support for neume notation encoded line by line, with each line encoded in a section. It is part of some refactoring for making the use of facsimile more generic than it now is in the Neon editor. The changes are essentially adjustments backward compatible with the Neon editor where the MEI loaded is cast off in distinct <staff> elements pointing to a facsimile zone. Staves are now expected to be wrapped into section elements with a @type attribute. It breaks the rule that Verovio should not rely on @type, but no other reasonably simple solution could be found.

The encoding structure expected is a follow:

<section>
  <pb/>
  <sb/>
  <section type="neon-neume-line">
    <staff n="1">
      <!-- content of the first line -->
    </staff>
  </section>
  <sb/>
  <section type="neon-neume-line">
    <staff n="1">
      <!-- content of the second line -->
    </staff>
  </section>
  <sb/>
  <section type="neon-neume-line">
    <staff n="1">
      <!-- content of the third line -->
    </staff>
  </section>
</section>

Internally, each section is converted into a pseudo Measure. This is identical to what is happening internally when mensural notation is cast off in Verovio, except the the cast off is actually pre-made with neume lines.

The PR also adds support for staff rotation when the layout is based on facsimile zones.

See examples in the PR to the DDMAL repository

@lpugin lpugin changed the title Add support for neume encoded line by line Add support for neumes encoded line by line Jan 10, 2024
@lpugin lpugin requested a review from ahankinson January 10, 2024 08:04
@lpugin lpugin force-pushed the develop-facsimile-neume-line branch from 889ef0a to cd19e49 Compare March 11, 2024 12:38
yinanazhou and others added 28 commits April 22, 2024 18:18
* This will still break with facsimile since the measure has no corresponding zone
Add an empty measure object only when none exist
Sync develop facsimile neume line with DDMAL
@lpugin lpugin merged commit af217c6 into develop May 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants