-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for neumes encoded line by line #3571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Special handling of `<section type="neon-neume-line">` for the neon editor
889ef0a
to
cd19e49
Compare
…-facsimile-neume-line
* This will still break with facsimile since the measure has no corresponding zone
Add an empty measure object only when none exist
Update: Develop facsimile neume line
Sync develop facsimile neume line with DDMAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for neume notation encoded line by line, with each line encoded in a section. It is part of some refactoring for making the use of facsimile more generic than it now is in the Neon editor. The changes are essentially adjustments backward compatible with the Neon editor where the MEI loaded is cast off in distinct
<staff>
elements pointing to a facsimile zone. Staves are now expected to be wrapped intosection
elements with a@type
attribute. It breaks the rule that Verovio should not rely on@type
, but no other reasonably simple solution could be found.The encoding structure expected is a follow:
Internally, each section is converted into a pseudo
Measure
. This is identical to what is happening internally when mensural notation is cast off in Verovio, except the the cast off is actually pre-made with neume lines.The PR also adds support for staff rotation when the layout is based on facsimile zones.
See examples in the PR to the DDMAL repository