Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(stream): add unit test for normalizing unmatched updates + fix typo #20366

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 3, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Should construct with new_ops rather than old ops.

This has been included in the cherry-pick PRs for 2.1 and 2.2.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the component/test Test related issue. label Feb 3, 2025
@kwannoel kwannoel added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 13e412c Feb 4, 2025
33 of 34 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-typo branch February 4, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants