refactor(proto): add LATEST const value for proto message version enums
#20359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
changed the title
PbAggNodeVersion::LATESTLATEST const value for proto message version enums
stdrc
commented
Feb 3, 2025
| // in case DEFAULT_KEY_COLUMN_NAME changes | ||
| COLUMN_DESC_VERSION_PR_13707 = 1; | ||
|
|
||
| // for test only | ||
| COLUMN_DESC_VERSION_MAX = 2147483647; |
There was a problem hiding this comment.
Removing MAX doesn't matter because this should only be used in unit tests before.
BugenZhao
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Shall we consider deriving it? (like https://docs.rs/strum/latest/strum/derive.EnumIter.html)
Signed-off-by: Richard Chien <[email protected]>
Done |
stdrc
added
the
ci/run-backwards-compat-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
By adding a
LATESTconst value to version enums likerisingwave_pb::plan_common::ColumnDescVersion, we can directly use this value when constructing new proto messages, avoiding updating all occurrence everytime we add a new version.Checklist
Documentation
Release note