Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg-cdc): fix role-based permission for rds #20347

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Jan 30, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As @edeesis use his own fork to submit codes and it's troublesome for me to submit my change to his branch. I move all the changes of the original PR here. Thanks for your effort.

The changes resolve #19020.
All the credit goes to @edeesis

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@edeesis
Copy link

edeesis commented Feb 5, 2025

Thanks for merging!

Merged via the queue into main with commit 51a8b08 Feb 5, 2025
34 of 39 checks passed
@KeXiangWang KeXiangWang deleted the wkx/fix-pg-cdc-role-permission branch February 5, 2025 03:32
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres CDC Permissions are not accurately validated with groups
3 participants