feat(iceberg): add support for creating new iceberg tables with partition keys #20340
+86
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Feb 5, 2025
| @@ -1446,6 +1502,7 @@ mod test { | |||
| r#type: "upsert".to_owned(), | |||
| force_append_only: false, | |||
| primary_key: Some(vec!["v1".to_owned()]), | |||
| partition_by: Some(vec!["v1".to_owned(), "identity(v2)".to_owned()]), | |||
There was a problem hiding this comment.
I think we should test all partition cases here, e.g
v1, identity(v1), truncate(4,v2), bucket(5,v1), year(v3), month(v4), day(v5), hour(v6), void(v1)
| let mut partition_fields = | ||
| Vec::<UnboundPartitionField>::with_capacity(partition_by.len()); | ||
| for partition_field in partition_by { | ||
| let re = Regex::new(r"\w+(\(\w+\))?").unwrap(); |
There was a problem hiding this comment.
This Regex can be created outside the for loop. Also according to v1, identity(v1), truncate(4,v2), bucket(5,v1), year(v3), month(v4), day(v5), hour(v6), void(v1), maybe we can check the prefix first and capture the param according to different transform type
jayakasadev
force-pushed
the
add_iceberg_partitions
branch
from
1f0f0c5 to
65e01f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note