Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): parallel service startup #20286

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 23, 2025

Signed-off-by: xxchan [email protected]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We can start e.g., Kafka and RisingWave in parallel.

risedev d is a highly frequent command for dev, so it's beneficial to speed it up.

Screen.Recording.2025-01-23.at.23.13.32.mov

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: xxchan <[email protected]>
Copy link

gru-agent bot commented Jan 23, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

@xxchan xxchan requested a review from BugenZhao January 23, 2025 15:14
@BugenZhao BugenZhao requested a review from stdrc January 24, 2025 05:38
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough as the idea is relatively simple

src/risedevtool/src/service_config.rs Outdated Show resolved Hide resolved
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this improvement. Would be better to parallelize according to topo-sorted dependency graph.

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan enabled auto-merge January 24, 2025 05:56
@graphite-app graphite-app bot requested a review from a team January 24, 2025 09:00
@xxchan xxchan added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 217dcfa Jan 24, 2025
28 of 29 checks passed
@xxchan xxchan deleted the xxchan/national-mockingbird branch January 24, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants