feat(compaction): support trivial move multi ssts #20284
Merged
+362
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/storage_support_trivial_move_multi_sst
|
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
…nto li0k/storage_support_trivial_move_multi_sst
…nto li0k/storage_support_trivial_move_multi_sst
…nto li0k/storage_support_trivial_move_multi_sst
8 tasks
zwang28
approved these changes
Feb 5, 2025
| } | ||
|
|
||
| // reset overlap_info | ||
| overlap_info.clear(); |
There was a problem hiding this comment.
minor: call create_overlap_info is equivalent to the new method clear.
There was a problem hiding this comment.
create_overlap_info has an additional box memory allocation overhead, but this is more intuitive. The semantics of clear are a bit unclean, but both work for me.
…nto li0k/storage_support_trivial_move_multi_sst
…nto li0k/storage_support_trivial_move_multi_sst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR improves the trival-move picker algorithm to support trivial-move tasks with multiple ssts.
Checklist
Documentation
Release note