feat: try adding FragmentRelation in meta store #20035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
force-pushed
the
peng/fragment-relation
branch
from
5cf9ecb to
a68fd78
Compare
yezizp2012
approved these changes
Jan 16, 2025
|
|
||
| let mut fragment_relations = BTreeMap::new(); | ||
|
|
||
| for (actor_id, dispatchers) in &new_actor_dispatchers { |
There was a problem hiding this comment.
Can you add some comments for it.
| @@ -429,6 +429,35 @@ impl CatalogController { | |||
| let inner = self.inner.write().await; | |||
| let txn = inner.db.begin().await?; | |||
|
|
|||
| let mut fragment_relations = BTreeMap::new(); | |||
|
|
|||
| for (fragment, actors, actor_dispatchers) in &fragment_actors { | |||
…dispatch info Signed-off-by: Shanicky Chen <[email protected]>
…d to prelude Signed-off-by: Shanicky Chen <[email protected]>
…new structs/enums Signed-off-by: Shanicky Chen <[email protected]>
…prove result processing Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/fragment-relation
branch
from
6458934 to
4ccb187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR attempts to add a
FragmentRelationtable to eventually replace the existingActorandActorDispatchertables, using dynamically generated Actors and Dispatchers.This PR currently only generates the
FragmentRelationentity when inserting into theActorDispatcherand then performs the insert; Our streaming logic doesn't use it.Part of #19106 .
Checklist
Documentation
Release note