fix(optimizer): can't apply pull_up_correlated_predicate_agg_rule with non-null-propagating expr #20012
+220
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h non-null-propagating expr Signed-off-by: xxchan <[email protected]>
chenzl25
reviewed
Jan 3, 2025
src/frontend/src/optimizer/rule/pull_up_correlated_predicate_agg_rule.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: xxchan <[email protected]>
chenzl25
reviewed
Jan 3, 2025
src/frontend/src/optimizer/rule/pull_up_correlated_predicate_agg_rule.rs
Show resolved
Hide resolved
Signed-off-by: xxchan <[email protected]>
chenzl25
reviewed
Jan 3, 2025
| .predicate() | ||
| .conjunctions | ||
| .iter() | ||
| .any(|expr| !Strong::is_null(expr, top_proj_null_bitset.clone())) | ||
| { | ||
| .all(|expr| Strong::is_null(expr, top_proj_null_bitset.clone())); |
There was a problem hiding this comment.
It should be any.
Suggested change
| .all(|expr| Strong::is_null(expr, top_proj_null_bitset.clone())); | |
| .any(|expr| Strong::is_null(expr, top_proj_null_bitset.clone())); |
| let mut top_proj_null_bitset = | ||
| FixedBitSet::with_capacity(top_project.base.schema().len() + apply_left_schema); | ||
| for (i, expr) in top_proj_exprs.iter().enumerate() { | ||
| if Strong::is_null(expr, agg_null_bitset.clone()) { | ||
| top_proj_null_bitset.insert(i + apply_left_schema); | ||
| } else { | ||
| top_proj_all_null = false; |
There was a problem hiding this comment.
When Strong::is_null return false, it means we can't get any useful information, so we shouldn't allow apply rule based on it.
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
|
@xxchan I don't see this commit in the latest tags |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
…h non-null-propagating expr (#20012) Signed-off-by: xxchan <[email protected]>
|
I think it can be cherry-picked into 2.2 which hasn't been released yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #19835
Previously we check whether the Agg is
countto decide whether the rule can be applied, but there are some other cases not considered, e.g.,coalesce. We should check whether the agg/expr is "null-propagating".The rule:
After:
Checklist
Documentation
Release note