Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deno UDF #17875

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat: remove deno UDF #17875

merged 1 commit into from
Jul 31, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 31, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To unblock dependency updates e.g., #17544, #13695.

We can revert this to bring it back after arrow-udf/arrow-udf#38 is resolved.

This is not a breaking change since it's only used in CI. Well, it's actually already enabled in production, but is not documented. So I think it's still fine.

cargo build -p risingwave_cmd_all --profile production --features "rw-static-link" --features all-udf && \

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from a team as a code owner July 31, 2024 01:17
@xxchan xxchan requested a review from BugenZhao July 31, 2024 01:17
@xxchan xxchan requested review from fuyufjh and wangrunji0408 July 31, 2024 01:22
@fuyufjh
Copy link
Member

fuyufjh commented Jul 31, 2024

Well, it's actually already enabled in production

You mean it was built in our previous release binaries? 🥵

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan
Copy link
Member Author

xxchan commented Jul 31, 2024

Well, it's actually already enabled in production

You mean it was built in our previous release binaries? 🥵

Yes. (I thought I proposed only enabling it in CI, but it seems not enforced.)

@xxchan xxchan enabled auto-merge July 31, 2024 02:25
@xxchan
Copy link
Member Author

xxchan commented Jul 31, 2024

Just tested with latest docker image that it is indeed enabled.

> docker run -it --pull=always -p 4566:4566 -p 5691:5691 risingwavelabs/risingwave:latest single_node

dev=> CREATE FUNCTION gcd(a int, b int) RETURNS int LANGUAGE javascript RUNTIME deno AS $$
    if(a == null || b == null) {
        return null;
    }
    while (b != 0) {
        let t = b;
        b = a % b;
        a = t;
    }
    return a;
$$;
CREATE_FUNCTION

@xxchan xxchan added this pull request to the merge queue Jul 31, 2024
@graphite-app graphite-app bot requested a review from a team July 31, 2024 02:41
Merged via the queue into main with commit 74702d5 Jul 31, 2024
36 of 37 checks passed
@xxchan xxchan deleted the xxchan/melodic-tarantula branch July 31, 2024 03:06
@xxchan
Copy link
Member Author

xxchan commented Jul 31, 2024

cc @bakjos, sorry for removing this feature. If you still need Deno UDF (in the short term), you can still use RisingWave 1.10, or you can revert this PR in your branch. In the long term, we can bring it back after arrow-udf/arrow-udf#38 is resolved.

@xxchan xxchan mentioned this pull request Jul 31, 2024
9 tasks
Xuanwo added a commit to arrow-udf/arrow-udf that referenced this pull request Sep 19, 2024
Close #38

This PR aims to remove deno entirely to eliminate the blocker preventing
us from using hyper 1.0.

We are no longer using `arrow-udf-js-deno`:
risingwavelabs/risingwave#17875. Meanwhile,
maintaining deno support significantly increases our burden. Users who
want to use arrow-udf in deno can directly use our js support.

---------

Signed-off-by: Xuanwo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants