-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove deno UDF #17875
feat: remove deno UDF #17875
Conversation
Signed-off-by: xxchan <[email protected]>
You mean it was built in our previous release binaries? 🥵 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes. (I thought I proposed only enabling it in CI, but it seems not enforced.) |
Just tested with latest docker image that it is indeed enabled.
|
cc @bakjos, sorry for removing this feature. If you still need Deno UDF (in the short term), you can still use RisingWave 1.10, or you can revert this PR in your branch. In the long term, we can bring it back after arrow-udf/arrow-udf#38 is resolved. |
Close #38 This PR aims to remove deno entirely to eliminate the blocker preventing us from using hyper 1.0. We are no longer using `arrow-udf-js-deno`: risingwavelabs/risingwave#17875. Meanwhile, maintaining deno support significantly increases our burden. Users who want to use arrow-udf in deno can directly use our js support. --------- Signed-off-by: Xuanwo <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
To unblock dependency updates e.g., #17544, #13695.
We can revert this to bring it back after arrow-udf/arrow-udf#38 is resolved.
This is not a breaking change since it's only used in CI.Well, it's actually already enabled in production, but is not documented. So I think it's still fine.risingwave/docker/Dockerfile
Line 73 in 8984ae2
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.