Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): make "insane" mode more insane, and tolerate inconsistency in some more places #16083

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Apr 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR:

  1. Embeds TroublemakerExecutor into DispatchExecutor in insane mode, for more trouble.
  2. Tolerates inconsistency in non-strict mode for:
    • StreamChunkCompactor
    • DynamicFilterExecutor
    • LookupCache
    • TopNCache

Now all nexmark queries except for q6 (containing OverWindow, which is a bit more complex, will fix in later PR) can run without panic in "insane" mode on my local environment. Will setup CI pipeline next step.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Apr 2, 2024

@stdrc stdrc changed the title embed TroublemakerExecutor inside DispatchExecutor feat(stream): make "insane" mode more insane, and tolerate inconsistency in some other places Apr 2, 2024
@stdrc stdrc marked this pull request as ready for review April 2, 2024 07:37
@stdrc stdrc changed the title feat(stream): make "insane" mode more insane, and tolerate inconsistency in some other places feat(stream): make "insane" mode more insane, and tolerate inconsistency in some more places Apr 2, 2024
@stdrc stdrc force-pushed the rc/log-suppressor-for-consistency-error branch from 9d78d26 to 61b1c36 Compare April 2, 2024 08:23
@stdrc stdrc requested a review from a team as a code owner April 2, 2024 08:23
Base automatically changed from rc/log-suppressor-for-consistency-error to main April 2, 2024 16:53
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stdrc stdrc added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 6e35a50 Apr 3, 2024
27 of 28 checks passed
@stdrc stdrc deleted the rc/more-insane branch April 3, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants