Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tcp and client feature for hyper 0.14 #13617

Closed
wants to merge 1 commit into from
Closed

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Nov 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Enable tcp and client features for hyper, or HttpConnector may not be used. FYI: https://docs.rs/hyper/0.14.27/hyper/client/connect/struct.HttpConnector.html

#13584

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx self-assigned this Nov 23, 2023
@github-actions github-actions bot added the type/fix Bug fix label Nov 23, 2023
@MrCroxx MrCroxx requested review from hzxa21, zwang28 and TingJianZheng and removed request for TingJianZheng November 23, 2023 08:36
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 23, 2023

pub fn new_http_client(config: &S3ObjectStoreConfig) -> impl HttpClient {
let mut http = hyper::client::HttpConnector::new();
// connection config
if let Some(keepalive_ms) = config.keepalive_ms.as_ref() {
http.set_keepalive(Some(Duration::from_millis(*keepalive_ms)));
}
if let Some(nodelay) = config.nodelay.as_ref() {
http.set_nodelay(*nodelay);
}
if let Some(recv_buffer_size) = config.recv_buffer_size.as_ref() {
http.set_recv_buffer_size(Some(*recv_buffer_size));
}
if let Some(send_buffer_size) = config.send_buffer_size.as_ref() {
http.set_send_buffer_size(Some(*send_buffer_size));
}
http.enforce_http(false);
let conn = hyper_rustls::HttpsConnectorBuilder::new()
.with_webpki_roots()
.https_or_http()
.enable_all_versions()
.wrap_connector(http);
let conn = monitor_connector(conn, "S3");
HyperClientBuilder::new().build(conn)
}

@zwang28 Will it cause #13584 if configurations in these lines are not enabled properly?

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 23, 2023

Features tcp and client are already included by risingave_connector. So this cannot actually fix the problem. But it is better added in the crate or in workspace dependency anyway.

@MrCroxx MrCroxx closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant