Skip to content

Commit

Permalink
remove redundant comment regarding error handling; update comment for…
Browse files Browse the repository at this point in the history
… barrier commit
  • Loading branch information
xzhseh committed Apr 15, 2024
1 parent c63e930 commit 5e35d06
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions src/connector/src/sink/snowflake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ impl SinkWriter for SnowflakeSinkWriter {
if is_checkpoint {
// finalize current streaming upload, plus notify snowflake to sink
// the corresponding data to snowflake pipe.
// note: if no data needs to be committed, then `commit` is simply a no-op.
self.commit().await?;
}
Ok(())
Expand Down
3 changes: 0 additions & 3 deletions src/connector/src/sink/snowflake_connector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,6 @@ impl SnowflakeS3Client {
let config = ObjectStoreConfig::default();

// create the s3 engine for streaming upload to the intermediate s3 bucket
// note: this will lead to an internal panic if any credential / intermediate creation
// process has error, which may not be acceptable...
// but it's hard to gracefully handle the error without modifying downstream return type(s)...
let opendal_s3_engine = OpendalObjectStore::new_s3_engine_with_credentials(
&s3_bucket,
config,
Expand Down

0 comments on commit 5e35d06

Please sign in to comment.